alanxz / SimpleAmqpClient

Simple C++ Interface to rabbitmq-c
MIT License
397 stars 213 forks source link

Explicitly set basic.qos.global #313

Open mkomel opened 1 year ago

mkomel commented 1 year ago

There is no way to explicitly set basic.qos.global when using BasicQosor BasicConsume. SimpleAmqpClient library always sets this to false for RabbitMq broker versions <v3.3.0 and to true for versions >v3.3.0. This made it impossible to set QoS with this library when used with quorum-type queues in RabbitMq >v3.3.0.

This pull request adds overrides to BasicConsumeand BasicQos, making it is possible to explicitly set basic.qos.global setting.

This patch fixes #276

mkomel commented 1 year ago

CI environment seems to be broken in this repo.

There are 4 tests failing, none of which is related to the changes within this pull request: 1: [ FAILED ] 4 tests, listed below: 1: [ FAILED ] connecting_test.connect_badvhost 1: [ FAILED ] connecting_test.open_badvhost 1: [ FAILED ] connected_test.channel_publish_full_rejected 1: [ FAILED ] connected_test.basic_message_header_roundtrip