search

alarofrunetotem / OrderHallCommander

7 stars 5 forks source link

Not working on most classes #15

Closed infinityinc closed 3 years ago

infinityinc commented 3 years ago

So far this only works on my Pally and Shaman - no %s or auto-fill parties for Mage, DH, Hunter.

Running pretty minimum addons - Elvui, Recount, Postal, DBM, Bagnon, Garrison/OrderHall/BfA commanders.

alar77 commented 3 years ago

Just tested on a demon hunter so I dont think issue is in class. Maybe some weird mission OHC cant manage? Do you have something like BugGrabber / Bugsack? Your error listing could really help

infinityinc commented 3 years ago

30x OrderHallCommander\cache.lua:901: attempt to compare number with nil [string "@OrderHallCommander\cache.lua"]:901: in function GetFullPermutations' [string "@OrderHallCommander\matchmaker.lua"]:691: in function?' [string "@OrderHallCommander\missionlist.lua"]:544: in function <OrderHallCommander\missionlist.lua:528>

[string "@OrderHallCommander\missionlist.lua"]:573: in function `ReloadMissions' [string "@OrderHallCommander\missionlist.lua"]:745: in function <OrderHallCommander\missionlist.lua:726>

string "=[C]": in function Show' [string "@FrameXML\UIParent.lua"]:2928: in functionSetUIPanel' [string "@FrameXML\UIParent.lua"]:2734: in function ShowUIPanel' [string "@FrameXML\UIParent.lua"]:2641: in function <FrameXML\UIParent.lua:2637> [string "=[C]"]: in functionSetAttribute' [string "@FrameXML\UIParent.lua"]:3492: in function `ShowUIPanel' [string "@FrameXML\UIParent.lua"]:1976: in function <FrameXML\UIParent.lua:1287>

Locals: self =

{ MAXLEVEL = defined @OrderHallCommander\OrderHallCommander.lua:137 modules =
{ } CancelTimer = defined @ElvUI\Libraries\Ace3\AceTimer-3.0\AceTimer-3.0.lua:147 IsBlacklisted = defined @OrderHallCommander\core.lua:165 GetAverageLevels = defined @OrderHallCommander\cache.lua:944 allEquipments =
{ } RebuildMissionCache = defined @OrderHallCommander\cache.lua:931 GetDataModule = defined @OrderHallCommander\data.lua:14 ActivateButton = defined @OrderHallCommander\core.lua:199 GetDifficultyColors = defined @OrderHallCommander\core.lua:226 GetMissionlistModule = defined @OrderHallCommander\missionlist.lua:16 SetDefaultModulePrototype = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:409 MAXQUALITY = defined @OrderHallCommander\OrderHallCommander.lua:140 GetResources = defined @OrderHallCommander\cache.lua:744 GetCacheModule = defined @OrderHallCommander\cache.lua:16 IsEnabled = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:451 GetCompletedMissionData = defined @OrderHallCommander\autocomplete.lua:570 MarkAsSeen = defined @OrderHallCommander\core.lua:289 ReloadMissions = defined @OrderHallCommander\missionlist.lua:566 RegisterMessage = defined @ElvUI\Libraries\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:90 UnregisterMessage = defined @ElvUI\Libraries\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:153 Pulse = defined @OrderHallCommander\missionlist.lua:642 hooks =
{ } db =
{ } PauseApply = defined @OrderHallCommander\missionlist.lua:495 Apply = defined @OrderHallCommander\missionlist.lua:498 SetEnabledState = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:424 Hook = defined @ElvUI\Libraries\Ace3\AceHook-3.0\AceHook-3.0.lua:274 EmptyPermutations = defined @OrderHallCommander\cache.lua:849 PushRefresher = defined @OrderHallCommander\missionlist.lua:557 Reserve = defined @OrderHallCommander\OrderHallCommander.lua:213 Reward2Class = defined @OrderHallCommander\cache.lua:432 ColorFromBias = defined @OrderHallCommander\OrderHallCommander.lua:149 NeedsTutorial = defined @OrderHallCommander\tutorials.lua:413 ShowPermutations = defined @OrderHallCommander\missionpage.lua:290 OnInitialized = defined @OrderHallCommander\core.lua:142 GetMissionpageModule = defined @OrderHallCommander\missionpage.lua:16 NewModule = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:235 GetMembersFrame = defined @OrderHallCommander\missionlist.lua:808 SortTroop = defined @OrderHallCommander\cache.lua:814 CleanPermutations = defined @OrderHallCommander\missionlist.lua:393 revision = "cc8ae7d" Unban = defined @OrderHallCommander\OrderHallCommander.lua:228 GetSelectedParty = defined @OrderHallCommander\matchmaker.lua:653 GetName = defined @ElvUI\Libraries\Ace3\AceAddon-3.0\AceAddon-3.0.lua:279 DumpPermutations = defined @OrderHallCommander\cache.lua:923 name = "OrderHallCommander" Refi

Dump I just did on my Mage. Hopped on my Shaman and it worked fine cashing 3 missions and selecting a couple of more. Zero addon differences between the two (unless ElvUI has class specific stuff interfering).

infinityinc commented 3 years ago

Just tested again with Mage and DH this morning - only addon on is OrderCommander - again no %s or autofill and a shitton of lua errors upon opening table. Should also be noted this a fresh install of WoW day after 9.2 launch.

p.s. the vitality heal a troop thingies haven't worked on any toon in a very long time.

alar77 commented 3 years ago

Fix attempt in 1.9.1

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.