aldryn / aldryn-blog

aldryn-blog IS DEPRECATED. PLEASE USE aldryn-newsblog!
Other
20 stars 35 forks source link

Categories #60

Closed Chive closed 10 years ago

stefanfoulis commented 10 years ago

Category should be multilingual. Btw, aldryn-news already has categories implemented. Just do it the same.

czpython commented 10 years ago

@stefanfoulis I talked to @Chive about this, but not sure if hvad is the best way to go since this app does not use it for the main model Post

stefanfoulis commented 10 years ago

Hvad is our multilingual library, so it's the only choice. We can continue to look for an alternative, but that is not in scope for this issue. The more features we add to aldryn-blog and aldryn-news, the more similar they are getting. At some point it may be worth merging the two and implementing clean namespacing so it can be used multiple times on the same site.

Chive commented 10 years ago

At some point it may be worth merging the two and implementing clean namespacing so it can be used multiple times on the same site.

Main issue here is that news.News is translatable while blog.Post isn't.

Category should be multilingual. Btw, aldryn-news already has categories implemented. Just do it the same.

Making the categories multilingual would mean introducing hvad to the project - wouldn't it make more sense to add a language field to category too? Isn't the better approach to either go multilingual all the way (like in aldryn-news) or use language fields - but no mixing?

edit: tbh, I'm not sure if making blog posts one-language-only was the best way to go

stefanfoulis commented 10 years ago

I agree about the spiecial case of multilinguality for blog being not ideal. But that is because we identified different requirements for a blog post. It should have a language, but not be translateable. If we'd switch to hvad for blog.Post, fallbacks would have to work perfectly.

I don't see anything special about category though, since it does not have the same characteristics as post. So it should just be done with hvad.

Chive commented 10 years ago

This should be it, feel free to merge :)