alexcorre / git-blame

Plugin for Atom Editor. Toggle git-blame annotations for the current file in the gutter.
MIT License
98 stars 58 forks source link

Uncaught Error: Repository has been destroyed #69

Open stelek opened 9 years ago

stelek commented 9 years ago

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 0.187.0 System: Mac OS X 10.10.2 Thrown From: git-blame package, v0.4.0

Stack Trace

Uncaught Error: Repository has been destroyed

At /Applications/Atom.app/Contents/Resources/app/src/git-repository.js:394

Error: Repository has been destroyed
  at GitRepository.module.exports.GitRepository.getRepo (/Applications/Atom.app/Contents/Resources/app/src/git-repository.js:394:15)
  at GitRepository.module.exports.GitRepository.getConfigValue (/Applications/Atom.app/Contents/Resources/app/src/git-repository.js:202:19)
  at GitRepository.module.exports.GitRepository.getOriginURL (/Applications/Atom.app/Contents/Resources/app/src/git-repository.js:206:19)
  at Object.toggleBlame (/Users/stelek/.atom/packages/git-blame/lib/controllers/blameViewController.js:26:40)
  at atom-workspace.toggleBlame (/Users/stelek/.atom/packages/git-blame/lib/git-blame.js:34:23)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/src/command-registry.js:246:29)
  at /Applications/Atom.app/Contents/Resources/app/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:558:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:396:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:182:20)

Commands

     -1:09.0 autocomplete-plus:confirm (atom-text-editor.editor.is-focused)
     -1:01.7 core:copy (atom-text-editor.editor.is-focused)
     -1:00.5 core:paste (atom-text-editor.editor.is-focused)
     -0:58.7 docblockr:parse-enter (atom-text-editor.editor.is-focused)
     -0:58.7 editor:newline (atom-text-editor.editor.is-focused)
  2x -0:31.8 core:save (atom-text-editor.editor.is-focused)
     -0:23.8 editor:select-line (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-atom-dark-ui)
     -0:23.6 application:open (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-atom-dark-ui)
     -0:22.0 build-tools-cpp:make (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-monokai.theme-atom-dark-ui)
     -0:22.0 window:save-all (atom-text-editor.editor.is-focused)
     -0:20.9 linter:lint (atom-text-editor.editor.is-focused)
     -0:09.5 core:delete (atom-text-editor.editor.is-focused)
     -0:02.5 core:save (atom-text-editor.editor.is-focused)
     -0:01.0 git-blame:toggle (atom-text-editor.editor.is-focused)
     -0:00.2 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:00.2 core:cancel (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "disabledPackages": [
      "linter",
      "linter-clang",
      "atom-ctags"
    ],
    "themes": [
      "atom-dark-ui",
      "monokai"
    ],
    "audioBeep": false,
    "excludeVcsIgnoredPaths": false
  },
  "git-blame": {}
}

Installed Packages

# User
Sublime-Style-Column-Selection, v1.2.3
auto-detect-indentation, v0.3.0
autocomplete-clang, v0.6.2
autocomplete-plus, v2.4.1
build-tools-cpp, v1.2.0
docblockr, v0.6.3
git-blame, v0.4.0
monokai, v0.12.0
reveal-active-file-context, v0.2.0
symbol-gen, v0.2.0
symbols-tree-view, v0.6.1
term2, v0.9.4
tree-view-git-projects, v0.5.0

# Dev
No dev packages
xdumaine commented 9 years ago

I'm getting this too. Basically unusable.

alexcorre commented 9 years ago

Can you add repro steps? I cant repro this

alexcorre commented 9 years ago

@xdumaine @stelek ^

stelek commented 9 years ago

I had a complex tree where root repo was not the same as some subtree repo and I tried blame on subtree.

alexcorre commented 9 years ago

ok sounds like could definitely cause an issue. Can you create a repository that reproduces the problem and link to it here?

stelek commented 9 years ago

Can't use a repo I used - it's confidential. I will try to reproduce it on github when I have time.