Closed claudio-viola closed 7 years ago
Savage but awesome 👍🏼
Thanks, but before issuing a PR can you check that all are recruitment agencies? I appreciate the submission but it's important that we keep the quality of the list as high as possible, and I don't have time to vet hundreds of domains.
Definitely agree on quality! thats why we have PRs. I did spend quite some time reviewing, another set of eyes would certainly help. I understand you don't have time.
anyway maybe some call themselves "consultancies" on their website and that could raise a doubt, and we can decide to leave them out but they are mostly recruitment agents for sure as they were extracted from the emails i received and my check was effectively looking at the kind of emails they sent.
Another set of eyes is needed for sure. if not you, maybe , someone else will have time to double check! I will review again next week
Thanks, but my point is that it's the responsibility of someone issuing a PR to make sure it contains no obvious problems. It's bad etiquette to submit a bunch of domains you know may be wrong (or more generally any code you know contains bugs) and leave it to the project's maintainer to sort them out.
I'm glad to take additions to the list, but in future please check every domain you're submitting to ensure non-recruitment-agencies like Pizza Hut (!) don't creep in.
Hey there, Do you want to remove dissolved agencies? Will remove Opportunities and jobmatchers although still it spammers to me
Claudio
Thanks, great stuff!
I hadn't considered dissolved agencies before. I think it's fine for them to stay on the list (maybe people will use it to filter their old emails?) unless someone new starts to use the domain.
kudos to https://helgeklein.com/blog/2015/02/extracting-all-email-addresses-from-a-gmail-label/ for extracting all my labeled emails! and some legendary bash scripting. To ease commit I have only grepped .co.uk domains... I parsed only the one that have sent me an email in the last 24 months. Please check as well as i had a mixture of recruitment and companies in my labeled emails!
I have 600 non .co.uk but surely mostly uk it recruitment based agencies that i have to review (last 24 months!)