search

alexpdev / torrentfile

Bittorrent Protocol v1 & v2 metafile creator, checker, editor, builder, reviewer. Assemble .torrent files from the command line.
Apache License 2.0
43 stars 4 forks source link

check outfile exists #188

Closed L4cache closed 6 months ago

L4cache commented 6 months ago

I copied the outfile determining code from class MetaFile, because it happens in func write(), and by that time files are already hashed, if it aborts then the hashing effort is wasted.

L4cache commented 6 months ago

Uh, any comments? Is this unacceptable?

alexpdev commented 6 months ago

It is not a significant enough change to warrant a pull request.

L4cache commented 6 months ago

Well then are you going to implement it- and possibly my other pull request- yourself? (and probably in a better way)

alexpdev commented 6 months ago

Yes probably one day. It's a good suggestion. In the future if you want to contribute something a little more substantial make sure you provide all the necessary code to make it work as well as some unit-tests to verify it doesn't break anything else. Make sure it passes all the coverage checks and CI/CD pipeline. And it would probably be best if you asked about it in an issue prior to doing all that work to make sure I will actually accept it.