alienator88 / Pearcleaner

A free, source-available and fair-code licensed mac app cleaner
https://itsalin.com/appInfo/?id=pearcleaner
Other
691 stars 17 forks source link

[BUG] Stuck on finding application files screen #20

Closed strash closed 4 months ago

strash commented 4 months ago

Describe the bug

It's stuck on "Finding application files..".

To Reproduce Steps to reproduce the behavior:

  1. Click to any app
  2. See infinite searching

Expected behavior

It shouldn't take that much time to find app files.

Desktop (please complete the following information):

Screenshots

Screenshot 2024-02-14 at 02 26 23 Screenshot 2024-02-14 at 02 26 44

Additional context

Add any other context about the problem here.

alienator88 commented 4 months ago

Hi, So I'm not able to reproduce this at all..hmm..have you tried fully uninstalling Pearcleaner from the Pearcleaner menu? Then reboot?

Screenshot 2024-02-13 at 5 25 53 PM Screenshot 2024-02-13 at 5 26 02 PM

alienator88 commented 4 months ago

There's been almost 300 downloads of this version so far and haven't seen other reports of this so far.

y-u-s-u-f commented 4 months ago

@alienator88 I'm getting this too.

alienator88 commented 4 months ago

Let me remove the progress bar and post the build here for you guys to test. Can you also try opening Console.app, start streaming and reproduce the issue. Then stop the stream and share the log here. Thanks.

y-u-s-u-f commented 4 months ago

Hey @alienator88!

The only thing I get on Console from PearCleaner is this:

default 21:06:56.790776-0800    Pearcleaner TrustSettingsUseXPC is enabled (via feature flags)
alienator88 commented 4 months ago

Could you try these 2 for me?

Pearcleaner_DEBUG_1.zip Pearcleaner_DEBUG_2_NoProgress.zip

alienator88 commented 4 months ago

This one too.

Pearcleaner_DEBUG_3.zip

strash commented 4 months ago

I did tried to reinstall fresh build from the release page and then all three debug builds you've provided. And the issue is still there.

y-u-s-u-f commented 4 months ago

Can confirm what @strash said.

alienator88 commented 4 months ago

I'll keep playing around with it, really odd that I can't reproduce this problem. I'm curious what your computers might have in common. What architecture are you guys running on, intel or arm?

For now, I moved the 2.6 release to a pre-release status, I'd say uninstall the current version and download 2.5 again until I get this sorted.

Thanks!

strash commented 4 months ago

I'll keep playing around with it, really odd that I can't reproduce this problem. I'm curious what your computers might have in common. What architecture are you guys running on, intel or arm?

I have M1 Mac mini if it helps.

alienator88 commented 4 months ago

I'm slowly reversing some of the changes I made between 2.5 and 2.6. Can you let me know how this one behaves? If still broken, I'll need to add some extra debug logging in there.

I tested 2.6 on my M1 Pro and an Intel Sonoma VM. None of them get stuck for me, it's so confusing 😂

I disabled the progress screen on this one so it should show the file view directly. Let me know if any file paths load up or if that's where it breaks.

Pearcleaner_DEBUG_4.zip

y-u-s-u-f commented 4 months ago

Hey

The 4th debug works. I'm on an M1 iMac BTW.

Yusuf.

alienator88 commented 4 months ago

Okay, so I'm narrowing this down between 2 possible changes, if you could test these two out for me. I really appreciate it!

Pearcleaner_DEBUG_ProgressNoRecursiveSearch.zip

I'm thinking the issue might be in this 2nd build here. I also added some debug logs that will be output to your Downloads directory, just called log.txt. If you could grab that for me for this build. Pearcleaner_DEBUG_NoProgressWithRecursiveSearch.zip

y-u-s-u-f commented 4 months ago

Hey Alin,

Thanks for reaching out! I tested both builds and here's what I found:

The first one worked perfectly fine for me. However, with the second build, I noticed that it shows 0 files/folders/items for every app. Let me know if you need me to help you with anything else!

Yusuf.

y-u-s-u-f commented 4 months ago

Oh also, here's the log: log.txt

alienator88 commented 4 months ago

Thanks for that. So it looks like the recursive search I added in the last update is causing it. Just not sure why it's only affecting some users. It might be a folder/file name causing it to crash. Can you take a look at your log.txt file and see if it matches exactly with all the folders in ~/Library/Application Support/folder? If there are any folders/files that you see in Finder that wasn't listed in the log, let me know what they are.

I added a few more debug logs to this build if you could try again and give me the new log: Pearcleaner.zip

y-u-s-u-f commented 4 months ago

Hey!

I tested the file, but unfortunately I got the same bug.

I don't really get what you mean to do with the log.txt file, but I attached it above.

alienator88 commented 4 months ago

So I know the build I just attached will not work. I'm trying to debug it and figure out why the recursive folder search is failing on your computer.

Can you delete the log.txt file from your Downloads, reproduce the issue again with the build from this comment and then give me the new log file it creates? Thanks.

y-u-s-u-f commented 4 months ago

Hey Alin,

Here's the new log.txt file: log.txt

alienator88 commented 4 months ago

Ahhh that was so helpful. The issue is the recursive search is not ignoring regular/hidden files. It should only be looking at directories. I was able to reproduce it by creating some empty files in my App Support folder. That's why I didn't see the issue, my App Support folder only contained folders and that's it.

Can you try this "hopefully" fixed version? Pearcleaner_FIXED.zip

Thank you so much for your time!

y-u-s-u-f commented 4 months ago

Hey! It finally worked. I tried the new zip you provided and it worked perfectly.

Thanks again for your time and help!

alienator88 commented 4 months ago

Couldn’t have done it without your help! Hard to troubleshoot bugs when I can’t reproduce them 😂 I’ll have v2.7 out later with this fix. Take care.