search

alienator88 / Pearcleaner

A free, source-available and fair-code licensed mac app cleaner
https://itsalin.com/appInfo/?id=pearcleaner
Other
618 stars 15 forks source link

[BUG] Button icons not showing in app deletion view #29

Closed greg1075 closed 2 months ago

greg1075 commented 3 months ago

Toggle button icons in app deletion view are showing a question mark inside a square placeholder instead of the correct button icons or labels

To Reproduce

  1. Click app to delete in mini mode
  2. See bottom of deletion window.

Expected behavior

I'm thinking the window is supposed to display button icons or labels?

Screenshots

Screenshot 2024-03-03 at 3 43 08 PM

Additional context

alienator88 commented 3 months ago

Out of curiosity, do you still see the issue if you install the SF Symbols app from Apple? If no, that might be why I’m not seeing the issue.

greg1075 commented 3 months ago

It works after installation, but my guess is most users won't have that installed and will have the same issue.

Regardless, I think a better idea than a toggle button might be a single one whose label changes i.e. Select All by default, [Deselect All] after the button has been clicked, and vice versa.

Also, I didn't find it immediately clear what the button at the botom right corner did. Rather than aA which is more of a text formatting label, I'd suggest abc ("textformat.abc" in SF Symbols) to make it clearer the button sorts by alphabetical order. For the second button, it's not clear to me what # means IMO. I'm not sure what a better symbol would be. Maybe the arrowtriangle.down.fill downward arrow... A possibility would be to have a button with alternating labels also, either with two symbols, or "abc" / "File Size".

alienator88 commented 2 months ago

I do like the textformat.abc option so I'll switch to that. I'll probably stick with the number pound sign for the sizes as it literally means number and couldn't find something else that relates better. I want to stay away from using word labels to keep it more minimalistic. Users can hover over any button in the app to get a tooltip that says what it does anyways.

Fixed in next version.