alienator88 / Pearcleaner

A free, source-available and fair-code licensed mac app cleaner
https://itsalin.com/appInfo/?id=pearcleaner
Other
618 stars 15 forks source link

v.3.2.0 - Can't uninstall from Menu Bar #36

Closed Hidlsh closed 2 months ago

Hidlsh commented 2 months ago

Describe the bug

I am having trouble finding the uninstall button for apps within the menu bar icon in v3.2.0?

Issue production video

https://github.com/alienator88/Pearcleaner/assets/67646781/9dfe3f95-65af-410e-98d0-c1ae40aa15bb

So basically, upon clicking on an app within the menu bar icon for Pearcleaner, nothing happens - except that it gets selected, as indicated with the green sidebar next to it.

A clear and concise description of what you expected to happen. In the video I click on the app I want to uninstall to select it, then I thought something would appear like a uninstall button to the right of the app. something like this maybe?

App should prompt some way to uninstall it after being pressed. CleanShot 2024-03-19 at 09 50 03@2x (I edited the trash bin icon from the regular Pearcleaner menu and put it into the menu bar version.)

Let me know if there's anything else I should explain better.

Desktop (please complete the following information):

Hidlsh commented 2 months ago

Also another thing I just thought of: After the uninstall button is pressed, it should maybe bring up a pop-up menu to the right of the app/ over the app? A window showing what's to be uninstalled

like how the fullsize Pearcleaner does. That way, since the uninstall trash icon button is already at the bottom, double clicking on the app within the menu bar could just open up this sort of pop-up window, instead of also having the trash icon I edited in - while continuing to show the app's version like usual. CleanShot 2024-03-19 at 09 58 17@2x

alienator88 commented 2 months ago

So that's really odd, it does popup a window to the side with all the files. At least on my end. Only difference I see is that I'm not updated to Sonoma 14.4 yet, I'm still on 14.3.1 I'm curious if the update to that version is what's breaking the popover from triggering. Let me test on my Ventura VM as well and see if it happens there.

Screenshot 2024-03-19 at 9 01 54 AM

Hidlsh commented 2 months ago

I've just reinstalled the app, and the issue still persists. Also, on your end, does it take a little bit before the side bar goes green when you select an app? like a small delay? maybe for me that's probably happening because the uninstall pop-up won't open 🤷🏾‍♂️

alienator88 commented 2 months ago

Yeah, my Ventura VM also works fine. I'll need to update to 14.4 and test it out there.

Screenshot 2024-03-19 at 9 11 00 AM

And no, it's pretty instant when I click the app and the popover shows to the side.

Can you open up Console.app and from the Action menu in the menubar, make sure "Include Debug Messages" is enabled. Then start a recording and reproduce the issue. Stop it when done and set the subsystem category to my app's bundle id. It should filter debug logs just for my app. Screenshot 2024-03-19 at 9 14 20 AM

Also, are you seeing the popover not work when you have the menubar option off and just using Mini Mode? Mini mode uses the same view as the menubar option, so I'm curious if that popover is broken as well.

alienator88 commented 2 months ago

I can't update my mac for a couple hours or so, I'm working at the moment. I'll test out 14.4 when I'm done.

Hidlsh commented 2 months ago

no worries, time is all yours

Hidlsh commented 2 months ago

Scroll to the bottom of this comment for solution btw

Can you open up Console.app and from the Action menu in the menubar, make sure "Include Debug Messages" is enabled. Then start a recording and reproduce the issue. Stop it when done and set the subsystem category to my app's bundle id. It should filter debug logs just for my app.

I pressed the pressed the start button to record the issue in the console app, then began to reproduce the issue. It was filling up with information as I selected apps through the mini menu, but nothing is shown after I filter with your app's bundleID within the subsystem category: CleanShot 2024-03-19 at 10 47 14@2x

Although nothing is showing under the subsystem category filter for your bundleID, there are results under the 'ANY' category: CleanShot 2024-03-19 at 10 51 24@2x Here's the file: console 03-19-2024.txt

Also, are you seeing the popover not work when you have the menubar option off and just using Mini Mode? Mini mode uses the same view as the menubar option, so I'm curious if that popover is broken as well.

figured it out as I was typing this loll

'Mini Window Mode' needs to be enabled for the sidebar popup to show within the Menu Bar version 😅 CleanShot 2024-03-19 at 11 38 14@2x

alienator88 commented 2 months ago

Oh my gosh LOL, you're so right. I almost never use regular mode, always in mini so I completely missed that. Let me take a look at it and I'll push out a quick fix 😂

alienator88 commented 2 months ago

Pushed out v3.2.1, thinking that should do it. Thanks for the issue report!