search

aliostad / CacheCow

An implementation of HTTP Caching in .NET Core and 4.5.2+ for both the client and the server
MIT License
847 stars 172 forks source link

Adding support for no-cache request header in CacheCow.Client #260

Closed BrettJaner closed 3 years ago

BrettJaner commented 3 years ago

Addresses issue #259

@aliostad, Let me know what you think

aliostad commented 3 years ago

Apologies for not getting back to you. But the code just in the line above does that check, no? What I mean, it wasn't broken to fix it:

https://github.com/aliostad/CacheCow/blob/master/src/CacheCow.Client/CachingHandler.cs#L99

aliostad commented 3 years ago

I don't believe this bug exists.

BrettJaner commented 3 years ago

Apologies for not getting back to you. But the code just in the line above does that check, no? What I mean, it wasn't broken to fix it:

https://github.com/aliostad/CacheCow/blob/master/src/CacheCow.Client/CachingHandler.cs#L99

The code above checks only the Response for the no-cache header value. My new code checks the Request.

aliostad commented 3 years ago

Oops! Yes, sorry. It makes sense.