search

allegro / handlebars-spring-boot-starter

Spring Boot auto-configuration for Handlebars
Apache License 2.0
109 stars 27 forks source link

Disable MessageSourceHelper in config #11

Closed smozely closed 9 years ago

smozely commented 9 years ago

This might be a simple question.

I want to disable the MessageSourceHelper, because I don't use it and the name message clashes with then name message I use in my domain model (as well as the message property when writing a error handler for development)

Wondering if there is already a way to do this ... Searching through the code I can't see it

plesiecki commented 9 years ago

Hello,

Well, right now there is no way to do this from the properties level but it seems reasonable and relatively easy because HandlebarsViewResolver has methods like setRegisterMessageHelper/withoutMessageHelper. Maybe you would like to make a proposal in form of a pull request?

smozely commented 9 years ago

Yip I'll do that ... Just wanted to check I wasn't missing something before attacking that.

Thinking that I'll add it into the HandlebarsProperties and then set it on the view resolver form there. Sound about right?

plesiecki commented 9 years ago

Sure!

plesiecki commented 9 years ago

fixed in 0.2.4

smozely commented 9 years ago

Great thanks, sorry I never found time to do the fix myself

plesiecki commented 9 years ago

No problem. Thanks for pointing it out