Rename starter - Githubissues

allegro / handlebars-spring-boot-starter

Spring Boot auto-configuration for Handlebars

Apache License 2.0

108 stars 26 forks source link

Rename starter #4

Closed snicoll closed 9 years ago

snicoll commented 9 years ago

Hi,

I am a member of the Spring Boot team and I've just noticed this project. Please rename your starter to not use the spring-boot-starter namespace that is reserved for official starters.

I'd suggest handlebars-spring-boot-starter

Thanks!

plesiecki commented 9 years ago

Hi,

Thanks for stopping by and pointing it out. Sure, I'm going to rename whole thing. Btw, please let me know if you'd consider taking a pull request to spring-boot.

Thank you for your consideration on this matter.

snicoll commented 9 years ago

Hello,

To be honest I don't know. I'd rather have it live here and see how it goes.

BTW, I had a closer look and I saw that you are using spring.handlebars as configuration prefix. Please don't use the sring.* prefix either as it is reserved as well.

Some more feedback:

I wouldn't use a prefix too lengthy so viewResolver can be renamed to something in a single word maybe?
You should enable the annotation processor in your build (spring-boot-configuration-processor) so that the relevant meta-data are generated for IDE support

Let me know if I can help.

plesiecki commented 9 years ago

Thanks for your all feedback again. I'm not sure if I should also rename repository or maybe I can leave it as it is. Could you please explain how it's supposed to be in this case?

wendigo commented 9 years ago

I personally think that the project name (artefact name) should be consistent with repo name.

plesiecki commented 9 years ago

I totally agree with you ;)

snicoll commented 9 years ago

I would rename the repo as well, yes.