allegroflare / allegro_flare

Application toolkit for Allegro 5
https://clubcatt.com/allegroflare
MIT License
35 stars 6 forks source link

Audit Recently Ported allegro_flare Components #189

Open MarkOates opened 2 years ago

MarkOates commented 2 years ago

Problem

A lot of components recently ported from allegro_flare were not fully safe for "painless use". Specifically, objects in AllegroFlare::ImageGenerator require al_init_primitives_addon to be called before they will work (otherwise will crash without warnings), however there are no guards to check for this case. Other recently ported components may not be checking for nullptr arguments, for example in AllegroFlare::ImageProcessing.

Solution

These recently added objects should be looked into to be sure they have the appropriate guards.

Notes

Here's an image of git history during the timeline of the those port changes:

image