search

alliander-opensource / AIFES

AI for the Future Energy System
Apache License 2.0
1 stars 1 forks source link

Review Notebook - SiaPartners #10

Closed FrankKr closed 1 year ago

FrankKr commented 1 year ago

Please review the Notebook provided by Alliander (which was a result of https://github.com/alliander-opensource/AIFES/issues/8).

Does the notebook work on your machine? Is the content clear? What additional functionality would be useful?

MartijnCa commented 1 year ago

Hi @dkunne-sia ! Just wanted to let you know that I added links to the notebook that needs a review and the relevant issue that Frank finished. Maybe you already finished the review. But if you have not had the chance to do so yet, then it should now be easier to find what you need to get started.

dkunne-sia commented 1 year ago

Wasn't able to run on own computer, due to access issues - but generally straightforward notebook. Well documented for the most parts with comments as guidance.

Noticed only MAE is taken as metric, I would argue it is valuable to assess the RMSE as well, given it's nature to penalize larger errors more. Together, both metrics can be compared to assess the variance in the error distributions of the forecast.

Furthermore, a method to compare multiple forecast models (for one or more locations) in one notebook would be a potential improvement.