search

alliander-opensource / AIFES

AI for the Future Energy System
Apache License 2.0
1 stars 1 forks source link

Review Notebook TenneT #11

Closed FrankKr closed 1 year ago

FrankKr commented 1 year ago

Please review the Notebook provided by Alliander.

Does the notebook work on your machine, Is the content clear, What additional functionality would be useful, ...

woutertromptennet commented 1 year ago

I just got rid of Conda ;-) venv/poetry is preferred. Personally I don't use Notebooks anymore (everything in IDE nowadays), but I can work perfectly fine with it.

Tip: never use relative paths, especially if you already use Pathlib.

Notebook is working on my machine. Got a nice feature importance graph in the end.

FrankKr commented 1 year ago

@FrankKr let's add os.chdir() to the root of the project at the start of the notebook.