almartin82 / projprep

a R package that helps read, clean up, and convert baseball projection data into auction prices.
7 stars 1 forks source link

matt duffy problem #31

Open almartin82 opened 8 years ago

almartin82 commented 8 years ago

what I thought was an error in the projections for #26 is actually... just how things are going. fangraphs (a reasonably complete but not outlandish projection universe) has 13 name collsions:

table(pos_df$fullname)[table(pos_df$fullname) > 1] %>% sort()

     Carlos Perez    Carlos Sanchez Christian Vazquez  Daniel Robertson 
                2                 2                 2                 2 
    Jesus Montero     Jose Gonzalez     Jose Martinez        Juan Perez 
                2                 2                 2                 2 
       Matt Duffy    Michael Miller    Michael Taylor     Tanner Murphy 
                2                 2                 2                 2 
      Tyler Moore 
                2 

I think our playerid match functions should pre-process these names, and attempt to match on name/team...