search

alopezlago / YetAnotherPacketParser

A parser to convert quiz bowl packets to different file formats
Other
8 stars 0 forks source link

YAPP ignores suggested changes in document #49

Open hftf opened 7 months ago

hftf commented 7 months ago

Documents may contain (intentionally or not) unaddressed suggested edits/tracked changes/revisions. In the WordprocessingML schema, suggested edits are represented primarily by the elements <w:ins> and <w:del>.

YAPP ignores these elements entirely, which means that both the original text (deletion) and suggested text (insertion) are missing from the output. This can result in missing substantive words, answerlines, etc. and a serious impact on gameplay.

Supporting suggested edits shouldn't be very involved: my first hunch is changing "r" to "r" or "ins" in the condition below. https://github.com/alopezlago/YetAnotherPacketParser/blob/00c6f583c552aa4d1112c4871148468110ad6957/YetAnotherPacketParser/YetAnotherPacketParser/Lexer/DocxLexer.cs#L92

alopezlago commented 6 months ago

I could look into this. Is this that common? I imagine reading tracked changes packets would be distracting.

hftf commented 6 months ago

It occasionally happens that comments and suggestions are left unaddressed, since packets tend to be proofread in a late crunch and many editors with overlapping responsibilities and responsivities are involved in the operation. The point is that YAPP ignores everything – both the original and the suggestion – causing missing substantive text or answerlines, which is a severe issue, while in other software you at least have a choice of how to view tracked changes.