alphagov / govuk-design-guide

This is a working repo for the GOV.UK Design Guide
0 stars 0 forks source link

Work in progress -- Visuals for design library #43

Closed nnagewad closed 1 month ago

nnagewad commented 2 months ago

Context

Preview

netlify[bot] commented 2 months ago

Deploy Preview for govukdesignlibrary ready!

Name Link
Latest commit 2eb2030524c27ce9eefbca64acd4d4ebf58a8128
Latest deploy log https://app.netlify.com/sites/govukdesignlibrary/deploys/66e2cc5c4804960008d7f0a8
Deploy Preview https://deploy-preview-43--govukdesignlibrary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nnagewad commented 2 months ago

Looks good, but something playing up with the layout when you start to zoom in on desktop?

Screenshot 2024-09-12 at 14 07 27

Wild. Wonder why that happens? Be curious to see how its been recreated.

calumryan commented 2 months ago

Looks good, but something playing up with the layout when you start to zoom in on desktop? Screenshot 2024-09-12 at 14 07 27

Wild. Wonder why that happens? Be curious to see how its been recreated.

Zoom over 125%. Maybe missing a CSS class somewhere, but a quick fix would be adding clear:both; on the <main> wrapper or .x-govuk-masthead.

joelanman commented 2 months ago

can't replicate on safari or chrome on mac - what browser is this?

calumryan commented 2 months ago

can't replicate on safari or chrome on mac - what browser is this?

Latest versions of Chrome and Firefox, also occurs at 90% zoom.

joelanman commented 2 months ago

yeh can't replicate in Firefox either, out of interest do you get the same issue here?

https://x-govuk.github.io/govuk-eleventy-plugin/

calumryan commented 2 months ago

yeh can't replicate in Firefox either, out of interest do you get the same issue here?

https://x-govuk.github.io/govuk-eleventy-plugin/

Resolved it โ€“ ran npm update to update the packages, probably as Iย haven't opened the site for a few weeks