search

alphazero / jredis

Java Client and Connectors for Redis
http://code.google.com/p/jredis/
Apache License 2.0
316 stars 136 forks source link

UR.2 -with-dependencies jars have duplicate classes #8

Closed alanharder closed 14 years ago

alanharder commented 14 years ago

For example, jredis-core-ri-a.0-SNAPSHOT-jar-with-dependencies.jar has 1 copy of the "api" code (the dependency), but 2 copies of all the "ri" classes.

alphazero commented 14 years ago

Thanks Alan for reporting this - I'll put it on the todo list for the next release. (I am assuming this is not causing any problems for you beyond a slight jar bloat.)

alanharder commented 14 years ago

right :-)

alphazero commented 14 years ago

Inspecting the jar content (using either jar -xf jredis-core-ri-a.0-SNAPSHOT-jar-with-dependencies.jar or unzip) doesn't show any duplicate content under org/jredis/ri. If you are referring to various instances of classes with $n in the name (such as ConnectionBase$1) those are inner classes.

alphazero commented 14 years ago

This was a maven issue: http://jira.codehaus.org/browse/MASSEMBLY-355

Fixed in http://github.com/alphazero/jredis/commit/fd7724e94b75fcd1d786faafa1ffdaad698c417e