search

alveusgg / data

Shared data repository for Alveus.gg projects
Other
9 stars 7 forks source link

Incorporate native habitat data and info sources #22

Closed itsjayway closed 1 year ago

itsjayway commented 1 year ago

Resolves #20

itsjayway commented 1 year ago

running npm install added

"license": "SEE LICENSE IN LICENSE.md", entry to package-lock.json; I can add it to this PR if it would help

MattIPv4 commented 1 year ago

You should be running npm ci, not npm install, which will maintain the current lockfile state.

MattIPv4 commented 1 year ago

Could you run npm version --no-git-tag-version minor and push that up, so the version gets bumped with this change, please?

pjeweb commented 1 year ago

For the chickens. Would it be more correct to list them all as domesticated and not the country they were bred (USA/China)? Or we can make the field origin instead of (native). Imho we can also null native entries if they aren't wild species?!

MattIPv4 commented 1 year ago

For the chickens. Would it be more correct to list them all as domesticated and not the country they were bred (USA/China)? Or we can make the field origin instead of (native).

From an educational perspective, I think it's useful to list where they originally came from. I think we can add (Domesticated) afterwards though (the donkeys + winnie + some of the chickens already have this).

I think we should probably avoid the nomenclature of an origin prop here, as that might be misinterpreted to be the origin of the specific ambassador, rather than the species as a whole.

Imho we can also null native entries if they aren't wild species?!

I think null leaves a lot of ambiguity, I think having an explicit bit of text that explains the situation each time is probably better. For example, it is much more useful to say to folks that Miley's species is bred in captivity than it is to just not list anything.