search

alveusgg / data

Shared data repository for Alveus.gg projects
Other
9 stars 5 forks source link

Add hosts object for Animal Quest #31

Closed jinitsuga closed 1 year ago

jinitsuga commented 1 year ago

adding a list of hosts (only Maya for now) to this package, as suggested by pjeweb on issue #246 from the website (found here)

jinitsuga commented 1 year ago

You'll want to update the type of host in AnimalQuest to be a key of hosts, so that you get type-safety This should take care of hosts type. Added hostNames object for whenever another host is added, so Typescript lets you know the host info should be added to hosts as well. Tried to keep it as robust as possible!

MattIPv4 commented 1 year ago

Would you mind creating a separate PR in the website repo that just bumps the data version and updates the animal quest pages to pull from this new object, just so any further data updates aren't blocked until your full hover card PR is merged?

Ty for the work on this!

jinitsuga commented 1 year ago

For sure! I'll get at it tomorrow. And thank YOU for the patience and explanations!

jinitsuga commented 1 year ago

Would you mind creating a separate PR in the website repo that just bumps the data version and updates the animal quest pages to pull from this new object, just so any further data updates aren't blocked until your full hover card PR is merged?

Ty for the work on this!

Don't wanna cause more unnecessary chaos so I'll just ask: Since I'm apparently unable to fork alveusgg more than once(already forked and main branch is the hover cards PR) -- should I make a separate branch, reset to a commit prior to my work for the cards and work on these changes from there and PR those? Thanks for any help :smile_cat:

MattIPv4 commented 1 year ago

Yes, that would be the standard development flow, a branch for each feature you're working on.