showing images in grid layout

[ak2711]

grid layout can be used to display images like this one

[thecskc]

This can be done using a recycler view with a grid layout manager with a span of 4

[cpg]

It's a nice idea. How to represent folders of images may also need some thought.

@ak2711 Please specify if you will be working on that or not.

[ak2711]

i would definitely like to work on it. folders can also be implemented like the following

[shashvat-kedia]

I would like to work on this issue

[cpg]

@sd1998 Please don't. Focus on the other issue you said you would be working on first #255

[mohitsvnit]

I would like to work on this issue.

[mohitsvnit]

In "Welcome to amahi" server shares/demo/photos only contains images. Can it also contains folders?

[cpg]

potentially, yes.

maybe do it in two parts. 1) start by assuming it does not. 2) later you can add that functionality if it makes sense.

[mohitsvnit]

OK. Because if folder exist then I have to create one separate fragment for that. First I will work on it assuming that folder does't exist. Can you tell which image format application is supporting?

[cpg]

I don't remember offhand, but for sure png, jpg and possibly gif

[mohitsvnit]

@cpg and @csoni111 Should I create different fragment say ServerFileImageFragment for images having grid structure or should modify ServerFileFragment so that if images comes then it uses grid structure else use linear structure? Please provide your valuable suggestion

[csoni111]

I think it would be better to modify ServerFileFragment. Duplicating the whole code for a single line change does not make sense.

[mohitsvnit]

@csoni111 I am thinking to change Listview into RecyclerView. What do you say?

[csoni111]

Yes do that but make sure you don't break any previous functionality.

[mohitsvnit]

@csoni111 functionality of ServerFileAdapter class is depends on multiple classes. Entire architecture seems really complex. I will try to complete it asap.