amahi / android

Amahi Android App
GNU General Public License v3.0
165 stars 276 forks source link

navigation drawer improvements #365

Closed cpg closed 6 years ago

cpg commented 6 years ago

The following are some changes I would suggest we do for the nav drawer:

arihant-001 commented 6 years ago

ways in which above changes can be implemented:

@cpg, @octacode please give your suggestions.

cpg commented 6 years ago

I am not sure about the Selected Server: ... because I think Selected is implicit and the colon may be superfluous.

The icons look great.

I kind of like the color selections in the circles (the color chosen were kind of a nice selection, which was, let's just say unusual for the typical developer), but perhaps a single color is more mainstream. If you choose a blue, please use a blue that is compatible with the rest of the app's blue colors. I like https://coolors.co/ and you can fix one color and it find shades for it automatically.

arihant-001 commented 6 years ago

From above, I came to the following conclusion:

  1. Selected will be use in place of Server text (or neither of them is necessary. Only server name would be enough to understand that this is server)
  2. This color for servers will be fine. This is the app primary color (used for toolbar/ action bar) servers

There still one thing left to discuss, the amahi logo in the circle. @cpg should we replace it with this this

octacode commented 6 years ago

Also for the first time when no server is selected, list of servers will be shown and flip arrow would be invisible.

I would like to keep the present implementation of keeping the first server as default. Usually people have a single server and the first server is default.

The color (primarycolor) and the icon looks great to me. However, the letters W and T aren't actually in the center of the circle, If my eyes are right. Try to make them center align.

However the BIG Amahi dice backdrop looks pretty wierd to me. We should decrease the height of the navigation_header. Maybe that'll look better.

Also, I'd suggest to reduce the font of the server name (Welcome to Amahi) under Selected HDA: in the navigation header. It looks a bit superfluos to me.

Yes, we should remove the Amahi logo from the ActionBar in this activity but not from all other activities.

arihant-001 commented 6 years ago

@octacode I will improve the drawer as suggested above.

octacode commented 6 years ago
cpg commented 6 years ago

clarification. i thinkSelected is implicit, which means it's not necessary. hence Server should be enough