search

amahi / android

Amahi Android App
GNU General Public License v3.0
165 stars 277 forks source link

Moving from dagger-1 to dagger-2 #597

Open cpg opened 4 years ago

cpg commented 4 years ago

Describe the issue Dagger-2 has been released and we should move to it

chirag-jn commented 4 years ago

Once this issue is resolved, we can easily start solving #540

chirag-jn commented 4 years ago

After moving to Dagger 2, change the play-services-cast-framework library version used too. For discussions, refer #671

FareesHussain commented 3 years ago

Switching to Hilt would be better than dagger 2 right?!

chirag-jn commented 3 years ago

Switching to Hilt would be better than dagger 2 right?!

Hilt seems to be built above Dagger 2 only. If you can go ahead and work on it, it would be nice!

Prakhar-Agarwal-byte commented 3 years ago

Switching to Hilt would be better than dagger 2 right?!

Hilt seems to be built above Dagger 2 only. If you can go ahead and work on it, it would be nice!

Hilt is still in alpha and we should take caution in using it in production (my opinion). What I think is first we should move to Dagger 2 then later we can add Hilt as it is based on Dagger only.