search

amahi / android

Amahi Android App
GNU General Public License v3.0
165 stars 277 forks source link

Added Shimmer Loading Effect #719

Closed Prakhar-Agarwal-byte closed 3 years ago

Prakhar-Agarwal-byte commented 3 years ago

@cpg I have added the new shimmer loading effect. I have attached a video of the new loading effect below. Fixes #712. In my opinion, it makes the app look more responsive than the current loading effect.

https://user-images.githubusercontent.com/17739006/103395955-aad09880-4b56-11eb-8184-9801a0dd424b.mp4

chirag-jn commented 3 years ago

I am able to see "No Files" when the shimmer effect is loading. Can we rather show "No Files" when the shimmer effect stops loading and is unable to find any file?

Prakhar-Agarwal-byte commented 3 years ago

I am able to see "No Files" when the shimmer effect is loading. Can we rather show "No Files" when the shimmer effect stops loading and is unable to find any file?

This issue is not caused by the shimmer effect and I think I can fix this in the next PR to keep this PR specific to the shimmer loading effect only.

chirag-jn commented 3 years ago

I am able to see "No Files" when the shimmer effect is loading. Can we rather show "No Files" when the shimmer effect stops loading and is unable to find any file?

This issue is not caused by the shimmer effect and I think I can fix this in the next PR to keep this PR specific to the shimmer loading effect only.

Please try to fix it in this PR itself.

Prakhar-Agarwal-byte commented 3 years ago

I am able to see "No Files" when the shimmer effect is loading. Can we rather show "No Files" when the shimmer effect stops loading and is unable to find any file?

This issue is not caused by the shimmer effect and I think I can fix this in the next PR to keep this PR specific to the shimmer loading effect only.

Please try to fix it in this PR itself.

Okay I am on it.

Prakhar-Agarwal-byte commented 3 years ago

@chirag-jn Now it is working correctly, please see the video below :

https://user-images.githubusercontent.com/17739006/103413346-1d656680-4b9f-11eb-89e5-9c5d66c2461c.mp4

Prakhar-Agarwal-byte commented 3 years ago

Now Shimmer effect is accurately working :

https://user-images.githubusercontent.com/17739006/103474981-1ae95380-4dcf-11eb-84b4-f7e1fa246ef4.mp4

chirag-jn commented 3 years ago

Please rebase and fix conflicts @Prakhar-Agarwal-byte

github-actions[bot] commented 3 years ago

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

chirag-jn commented 3 years ago

Something seems wrong @Prakhar-Agarwal-byte. The branch doesn't seem to be rebased properly. Rather create a new PR instead?

Prakhar-Agarwal-byte commented 3 years ago

Something seems wrong @Prakhar-Agarwal-byte. The branch doesn't seem to be rebased properly. Rather create a new PR instead?

Yes, I am creating a new PR, actually, I did a mistake, that's why it wasn't rebased properly.

github-actions[bot] commented 3 years ago

Conflicts have been resolved. A maintainer will take a look shortly.

Prakhar-Agarwal-byte commented 3 years ago

I am closing this PR in favour of #748.