amahi / android

Amahi Android App
GNU General Public License v3.0
164 stars 279 forks source link

Adding Default System Language Option in Settings #733

Closed Prakhar-Agarwal-byte closed 3 years ago

Prakhar-Agarwal-byte commented 3 years ago

Describe the issue In the Amahi Android app, we can add a new feature that allows users to select the default system language as the in-app language as well. It will make a great feature, as mostly users prefer to use the language in their apps same as the system language. If the app does not support the language which the user has set as system language then the app will use English Language as in-app language.

To Reproduce or Feature details Steps to reproduce the behavior:

  1. Go to Settings
  2. Click on Language
  3. Select System Default from the dialog
  4. See that the language changes to the system language.

Expected behavior

In the language chooser dialog box, a new option should be added named "System Default". On choosing this option the in-app language should change to the system language if it is supported by the app or else it should fallback to English as the in-app language.

Demo Recording

In the demo below, I first changed the system language to Hindi then I chose the System Default option in the Language dialog box. Now, we see that the language automatically changes to the chosen system language i.e. Hindi, and since Hindi is supported by the app, therefore, our in-app language changes to Hindi. If that wouldn't be the case then it would have fallen back to English. Finally, for confirming that it works I changed it to another language as well.

https://user-images.githubusercontent.com/17739006/106027356-d496c400-60f0-11eb-80a9-58e5c9e3be3e.mp4

Smartphone (please complete as much of the following information as possible):