amazon-archives / aws-robomaker-sample-application-persondetection

Use AWS RoboMaker and demonstrate the use of Amazon Rekognition to recognize people's faces and Amazon Polly to synthesize speech.
MIT No Attribution
25 stars 18 forks source link

Launch files are incorrect for physical TB application #29

Closed AAlon closed 5 years ago

AAlon commented 5 years ago

I suspect the changes at https://github.com/aws-robotics/aws-robomaker-sample-application-persondetection/pull/4 were only tested on RoboMaker and not on a physical robot.

Specifically, moving <rosparam if="$(eval image_topic != '')" param="/$(arg param_prefix)/subscription_topic" subst_value="true">$(arg image_topic)</rosparam> to the global scope caused it to override the subscription topic of the video streamer node, while it should have only affected the encoder node. And I think that's not the only issue. Opened https://github.com/aws-robotics/aws-robomaker-sample-application-persondetection/pull/30 to try and address some of the problems found.