kinesis_video_streamer.launch receives a stream_config_file, not config_file
arg is the correct element type to use when passing arguments to included files, not param
subscription_topic was set for the entire global context of the launch file, affecting both kinesis_video_streamer and h264_encoder and having them both subscribe to raspicam_node/image. Only the encoder should subscribe to raspicam_node/image. I'm not sure the change I made is what we want though, it probably isn't (it just reverts to the state before https://github.com/aws-robotics/aws-robomaker-sample-application-persondetection/pull/4). Need to rethink and review this more.
Tested it works on TB.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
*Issue #29
Description of changes:
kinesis_video_streamer.launch
receives astream_config_file
, notconfig_file
arg
is the correct element type to use when passing arguments to included files, notparam
subscription_topic
was set for the entire global context of the launch file, affecting both kinesis_video_streamer and h264_encoder and having them both subscribe toraspicam_node/image
. Only the encoder should subscribe toraspicam_node/image
. I'm not sure the change I made is what we want though, it probably isn't (it just reverts to the state before https://github.com/aws-robotics/aws-robomaker-sample-application-persondetection/pull/4). Need to rethink and review this more.Tested it works on TB.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.