amazon-archives / aws-robomaker-sample-application-persondetection

Use AWS RoboMaker and demonstrate the use of Amazon Rekognition to recognize people's faces and Amazon Polly to synthesize speech.
MIT No Attribution
25 stars 18 forks source link

simulation_common has incorrect dependency definition #46

Open AAlon opened 5 years ago

AAlon commented 5 years ago

In: https://github.com/aws-robotics/aws-robomaker-sample-application-persondetection/blob/master/simulation_ws/src/aws_robomaker_simulation_common/package.xml

The package declares dependency on moveit_ros and dwa_local_planner but it doesn't seem like these are actually used.

On the other hand, the package uses move_base_msgs and geometry_msgs but doesn't declare them as dependencies: https://github.com/aws-robotics/aws-robomaker-sample-application-persondetection/blob/master/simulation_ws/src/aws_robomaker_simulation_common/nodes/route_manager#L24

Please audit and fix the dependency definitions.

mm318 commented 4 years ago

The master branch has been renamed to ros1, so the link to the relevant package.xml file is: https://github.com/aws-robotics/aws-robomaker-sample-application-persondetection/blob/ros1/simulation_ws/src/aws_robomaker_simulation_common/package.xml