Closed wywyWang closed 1 year ago
Hi,
Thanks for reaching out regarding our work and for your catching this missing definition.
You are right, here train_parameters
should be replaced with parameters
. For similar call, check the following test: https://github.com/amazon-science/explainable-trajectory-prediction/blob/main/test/test_causal_trajectron_train.py#L25
We will fix this error soon.
Best, Osama
Hi Osama,
Thanks for your clarification. I could create a pull request to fix this directly if this would be more convenient for you.
Best, Wei-Yao
Sure, would be glad to merge it.
I just opened a pull request in pull request #14 . Can close this after the merge. Thank you!
Thanks for your pull request. I merged it, so closing this issue.
Hi,
Thank you for your interesting work! I wondered about what the
train_parameters
contains in line 70 in bin/train_trajectron.py. I tried to replace it withmodel_parameters
but it would encounter an error that the dict object has no attribute seed.Thank you!
Best, Wei-Yao