search

amazon-science / explainable-trajectory-prediction

Official code repository for the ICLR 2022 paper "You Mostly Walk Alone: Analyzing Feature Attribution in Trajectory Prediction".
https://openreview.net/forum?id=POxF-LEqnF
Apache License 2.0
13 stars 4 forks source link

Missing defined variable train_parameters in bin/train_trajectron.py #12

Closed wywyWang closed 1 year ago

wywyWang commented 1 year ago

Hi,

Thank you for your interesting work! I wondered about what the train_parameters contains in line 70 in bin/train_trajectron.py. I tried to replace it with model_parameters but it would encounter an error that the dict object has no attribute seed.

Thank you!

Best, Wei-Yao

os1a commented 1 year ago

Hi,

Thanks for reaching out regarding our work and for your catching this missing definition.

You are right, here train_parameters should be replaced with parameters. For similar call, check the following test: https://github.com/amazon-science/explainable-trajectory-prediction/blob/main/test/test_causal_trajectron_train.py#L25

We will fix this error soon.

Best, Osama

wywyWang commented 1 year ago

Hi Osama,

Thanks for your clarification. I could create a pull request to fix this directly if this would be more convenient for you.

Best, Wei-Yao

os1a commented 1 year ago

Sure, would be glad to merge it.

wywyWang commented 1 year ago

I just opened a pull request in pull request #14 . Can close this after the merge. Thank you!

os1a commented 1 year ago

Thanks for your pull request. I merged it, so closing this issue.