amethyst-framework / amethyst

Amethyst is a Rails inspired web-framework for Crystal language
https://github.com/amethyst-framework
MIT License
648 stars 46 forks source link

Add support for sessions #48

Closed drujensen closed 8 years ago

drujensen commented 8 years ago

Very rudimentary support for sessions. This is hard coded to an in-memory only solution. Adding support for an adapter would be needed to for other strategies.

bararchy commented 8 years ago

@drujensen This looks nice :) When we will merge the HEAD channel, I want to change the way generate_sid is working, by using UUID instead of just random bytes

Codcore commented 8 years ago

Why did you closed this pull request?Sorry, I can't look at the code, because of some sad incident in my life

drujensen commented 8 years ago

Sorry to hear things aren’t going so well for you.

The tests weren’t passing. I decided to clean it up and get better test coverage. I will resubmit soon.

On Aug 13, 2015, at 1:31 AM, Andrej Yaroshuk notifications@github.com wrote:

Why did you closed this pull request?Sorry, I can't look at the code, because of some sad incident in my life

— Reply to this email directly or view it on GitHub https://github.com/Codcore/amethyst/pull/48#issuecomment-130574096.