search

amilajack / caster

A Chromecast client based on the new (CASTV2) protocol
https://amilajack.github.io/caster/
MIT License
2 stars 2 forks source link

Unable to use 0.0.2-0 #17

Open sneljo1 opened 5 years ago

sneljo1 commented 5 years ago

Is it possible that 0.0.2-0 didnt get build correctly before publishing? The built lib folder seems to be missing.

amilajack commented 5 years ago

Thanks for pointing this out! Just fixed this in https://github.com/amilajack/caster/commit/74286b4586f62b336134a530f8af7088ba7bf79c. I renamed the lib folder to dist.

amilajack commented 4 years ago

Just wanted to follow up with you on this to check if this worked for you.

sneljo1 commented 4 years ago

I'm actually working on this this weekend. It didn't end up working out for me. I'm having multiple issues. I'm trying to fix these locally with a fork. I'm not sure if it's my configuration or something in the module.

  1. Unexpected token "static"

    ERROR in ./node_modules/@amilajack/castv2-client/dist/senders/application.js 19:16
Module parse failed: Unexpected token (19:16)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| 
| class Application extends _sender.default {
>   static APP_ID = 'CC1AD845';
| 
|   constructor(client, session) {
@ ./node_modules/@amilajack/castv2-client/dist/index.js 89:42-74
@ ./src/main/features/core/chromecast/chromecastManager.ts
@ ./src/main/features/index.ts
@ ./src/main/app.ts
@ ./src/main/index.ts

  2. @amilajack/castv2-client/dist/index.d.ts' is not a module. -> This issue seems to be resolved when not using outFile in tsconfig.

sneljo1 commented 4 years ago

1 seems to be solved adding @babel/plugin-proposal-class-properties. If you want I can create a PR if you haven't already fixed this soms other branch.