ampache / ampache-docker

Ampache docker package
http://ampache.org
93 stars 68 forks source link

Default Config "local_web_path" value block subsonic #48

Closed YasserAntonio closed 4 years ago

YasserAntonio commented 4 years ago

Using the last version of ampache with the tag nosql on an arm I wanted to get a subsonic client on IOS to free my phone's memory and keep playing songs. I wanted to try ISub but got some troubles to make it work since the default value in the config (ampache.cfg.php) for local_web_path is http://localhost/ampache which make subsonic unable to load songs requested by the client. I didn't find the source of the problem alone , it appears that some other users had this issue for quite a long time ago but the issue was closed without changes in the default config even if a working value for local_web_path was proposed: https://github.com/ampache/ampache/issues/1639

Since I find a lot of posts, issues , forum discussion related to this maybe it should be considered to set the default value of local_web_path at http://localhost as it's the only one working and to remove "/ampache" at the end because it create troubles.

About the difference that required changes that could be needed concerning the local_web_path I can see only one cas the it could be different from http://localhost : In the case you use a reverse proxy with a dns server which require to replace lolcahost with the target url and to add dns = xxx.xxx.xxx.xxx in the docker-compose service using the ampache image)

I add the issue here since I use the docker image and I dont know if the problem remain on ampache/ampache repo.

Everything is working with ISub by the way^^

lachlan-00 commented 4 years ago

the default local_web_path is null.

the semi colon in the config means it's commented out

; DEFAULT: none
;local_web_path = "http://localhost/ampache"
YasserAntonio commented 4 years ago

okey but still why the /ampache ? Is it useful in some situation ?

wagnered commented 4 years ago

For manual(non-docker) installation, Ampache is usually unpacked at /var/www/ampache, but the default document root of most web servers is '/var/www', local_web_path="http://localhost/ampache" adjusts the URL to the actually document root.

YasserAntonio commented 4 years ago

Oh okey makes sens, thanks for the explanation. I'm going to close it then.