amwatson / CitraVR

Port of the leading 3DS emulator, Citra — designed for playing 3DS homebrew and personal game backups in 3D on the go with your Quest.
GNU General Public License v3.0
741 stars 61 forks source link

Lubos VR180 immersive mode #32

Closed amwatson closed 9 months ago

amwatson commented 9 months ago

This changeset adds Lubos' VR180-style immersive-mode -- behind an experimental feature -- to the core CitraVR project

lvonasek commented 9 months ago

I see you removed my variant :-( Pity. I just tested it and the immersion is much lower. You shouldn't call it VR180 anymore as the view range is below 180°.

amwatson commented 9 months ago

I see you removed my variant :-( Pity.

I mean, it was effectively the same one, just a different constant. Just added it back, though (passing the scale factor as a uniform)

I was using "VR180" because I thought that's what you were calling it. I'll rename it to "Immersive Mode" because that avoids any specific connotations

lvonasek commented 9 months ago

I mean, it was effectively the same one, just a different constant.

I know it is just a constant but it makes a difference between a "very big screen" and "VR-like experience".

Just added it back, though (passing the scale factor as a uniform)

Great. I do not see it in the code, I guess it is not pushed yet. Thank you :)