Colours are messed up

[VedVid]

I'm playing standalone ASCII version on Windows 10. Release 0.10 worked well, but playing 0.11 is nearly impossible due to colour scheme. Walls are "covered" by FOV layer:

Solarized palette is not good either, because it's eye-tiring:

On screenshots I'm using cmder terminal emulator, but on default windows command line effect is the same.

Screenshot of Boohu 0.10:

[anaseto]

Does the problem persist if you toggle twice again the dark/light setting with = and then b? (just to be sure it's not because of some incompatibility of config between versions) I may have screwed something up, some of the drawing code was factorized during development of the last version. I'll have a look into it.

[VedVid]

It helped - after toglling dark/light settings, walls are displayed correctly even in default mode.

edit: I'm using different versions of Boohu in separate folder, so local config files should not overlap.

[anaseto]

There was indeed a bug when no config file was present (it did kind of a mix of the two dark/light themes). The above commit should fix the issue.

[VedVid]

Interesting... I build ASCII release from master by go get -u git.tuxfamily.org/boohu/boohu.git then go build.

Now, the default mode is this one:

but if I toggle FOV mode and quit game, then start it again, whole screen is, well, bright:
In that case, toggling FOV once results in regular light mode, and next switch to the default one.

[VedVid]

Ups, it's even more complicated. Let me post gif here:

[anaseto]

Oh, yes, hm, I've found the main culprit: I changed the way dark/light worked (now there is indeed a dark with green LOS, and a bright one), but the toggling for the windows 8-colour version only got half updated. I'll fix this asap.

[anaseto]

Hopefully now fixed with the last commit. Now there should be for the 8-colour palette a dark or light background, with green light in both cases.

Thanks for pointing out this issue!

[VedVid]

No problem, it's in my best interests as well ;)

Unfortunately, it still looks strange. I can switch between

and

This light blue is nice hue, but I don't think it's intended...

[anaseto]

Oops! Should be fixed now. The thing is, on my current OpenBSD machine I have to use the tcell backend and cannot even test myself the termbox backend I use for Windows, Linux and OS X binaries, portability is hard :-)

[VedVid]

In that case, it's good that I'm on Windows and have plenty of time. And Go environment set up already :)

Now dark FOV looks as it's supposed to look, but the light one is still problematic - whole screen has bright background, only foreground changes. And tiles in player's FOV are still green.

[anaseto]

The light one did work in fact as I intented after the theme change I did after people pointed out to me that the contrast between LOS background and the rest was too much, and the results looks ok with 16 colors.

But the everything bright one is indeed not very pretty with 8 colours, so I switch it back again to how it worked before for the 8-color version! :-)

[VedVid]

Thanks! :) I think we can close this issue now.

[anaseto]

Great! And thanks again for helping debugging this :)

[VedVid]

I'm glad I was able to help :)