search

andersevenrud / nordic.nvim

A nord-esque colorscheme for neovim
MIT License
174 stars 12 forks source link

Add support for lightspeed.nvim #53

Closed 9seconds closed 2 years ago

9seconds commented 2 years ago

This commit adds support for https://github.com/ggandor/lightspeed.nvim

CleanShot 2021-12-10 at 23 57 08@2x
gegoune commented 2 years ago

I think it made beacons fairly hard to spot,

Screenshot 2021-12-11 at 00 03 28

especially when entire viewport gets dimmed.

I think, given nature of the lightspeed plugin, that they should really stand out. What do you think?

andersevenrud commented 2 years ago

@gegoune From that cropped screenshot it looks OK to me. I'm going to install lightspeed to see how this looks on a larger scale and get back to you.

andersevenrud commented 2 years ago

@gegoune From just spending a little bit of time with it I didn't find it hard to spot/distinguish the different kinds of beacons that popped up. However, all eyeballs, monitors and terminal setups are made different, and I probably haven't spent enough time with it to get a proper "feel", so my experience might be a bit different than yours -- so I'm totally open to suggestions here :smile:

I'm not really sure why I haven't picked up lightspeed before, because this is awesome (!), so I will continue testing this tomorrow because it's getting a bit late here.

gegoune commented 2 years ago

Thanks for understanding. I will also look at it again in daylight with fresh eyes.

9seconds commented 2 years ago

It could be that colors are too dimmed now because I believe that original intensity is too big for Nord. It is possible to tune them replacing blue tones with yellow or red. I can try to do it after weekends

9seconds commented 2 years ago

I've got some spare minutes today. Please check a mentioned PR.

gegoune commented 2 years ago

Had a very quick look just now, way easier to see for me now. Thank you very much! Hopefully @andersevenrud will agree and merge it in. :)