andersevenrud / nordic.nvim

A nord-esque colorscheme for neovim
MIT License
174 stars 12 forks source link

Adjust treesitter text highlights #56

Closed andersevenrud closed 2 years ago

andersevenrud commented 2 years ago

Stylize certain treesitter highlights to improve visibility in formatted text documents, like Markdown.


Just saw that the Markdown treesitter parser was merged into nvim-treesitter, and tried it out. All of the sudden my files looked really flat :sweat_smile:

I'll have to look at some other filetypes that uses these same treesitter highlights to make sure nothing was really messed up... but I'm fairly confident.

Before:

before2

After:

after2

andersevenrud commented 2 years ago

Do you have any thoughts on this (or maybe have experience with some other filetypes I need to look out for) @gegoune ? :blush:

gegoune commented 2 years ago

I was to make a comment on new tree sitter's parser for MD. You are fast! :) There also is new make tree sitter parser which has no highlighting with nordic at all. I will check out this PR in few moments and report back.

andersevenrud commented 2 years ago

@gegoune Just a note on the new make parser, it seems to work fine for me :thinking: But if you have some issues with it just open an issue and I'll have a look!

Without TS: before3

With TS: after3

gegoune commented 2 years ago

Ah, make does work indeed, I was just checking on very simple Makefile which just happened to have no highlights applied except for one on : which I did not notice.

Please hide this comment after you read it. :)

gegoune commented 2 years ago

Markdown looks nice, good job! Couple of missing highlights and one typo I mentioned above.

andersevenrud commented 2 years ago

From what I can tell, these changes should look fine anywhere else too. So I'm going ahead with a merge here.

Thanks a lot for your time @gegoune . Really appreciate the hands-on :smile:

gegoune commented 2 years ago

Thank you for all your work on this amazing theme. I wish I could help, but I bet I cannot come up with anything visually pleasing. :)

andersevenrud commented 2 years ago

I bet you could. You seem to have a good eye for these kinds of things :)