search

andersevenrud / nordic.nvim

A nord-esque colorscheme for neovim
MIT License
174 stars 12 forks source link

fix: Better hl for `LspReference...` #90

Closed delafthi closed 2 years ago

delafthi commented 2 years ago

Change of LspReference... hl colors mentioned in #89. I used the same colors as in the original nord-vim colorscheme.

Here an example: lsp_reference_hl

I don't know why var_b is also highlighted. But the highlight is clearly distinguishable from the search results and also works on darker (blue) text.

Closes #89

andersevenrud commented 2 years ago

I don't know why var_b is also highlighted

I'm not at home today, so I can't test this myself. But this is just something with your setup, or is it a side-effect of changing the highlights ?

delafthi commented 2 years ago

I don't know why var_b is also highlighted

But this is just something with your setup, or is it a side-effect of changing the highlights ?

No it's not my setup and not a side-effect of this change. I think it is a bug of sumneko's lua-language-server (, or maybe I'm just wrong). I'll investigate this further.

andersevenrud commented 2 years ago

I think it is a bug of sumneko's lua-language-server

Aha! Thanks for the tip. I'll check it out when I'm back on Saturday :)

delafthi commented 2 years ago

I think it is a bug of sumneko's lua-language-server

I did some investigation this morning and opened an issue (sumneko/lua-language-server#1670).

andersevenrud commented 2 years ago

Just gave it a go, and it seems to be working just fine. Didn't have sumneko, but tsserver handled this well :)

Thanks!