search

andersnm / ExcelNumberFormat

Parse and render Excel number format strings
MIT License
79 stars 27 forks source link

Fix LookBackDatePart iteration #1

Closed igitur closed 6 years ago

igitur commented 6 years ago

Greetings.

I'm the coordinator on the https://github.com/ClosedXML/ClosedXML project and we could definitely use this library for the formatting of values in Excel formats. Thanks to @kendallb for pointing me in this direction.

This PR:

andersnm commented 6 years ago

Hi,

It's awesome if you can use this!

Although the ExcelNumberFormat project was recently incorporated into the ExcelDataReader project, and hadn't really planned to update this repo any further.

If it helps, I'd be happy to accept these PRs, and could maybe also backport the initial TimeSpan formatting support?

https://github.com/ExcelDataReader/ExcelDataReader/tree/develop/src/ExcelDataReader/Core/NumberFormat https://github.com/ExcelDataReader/ExcelDataReader/blob/develop/src/ExcelDataReader/NumberFormatString.cs

igitur commented 6 years ago

If you don't want to continue supporting this library, it's fine. I'll just mirror the classes from ExcelDataReader then. Just let me know.

But I do think other people could also benefit from this library. If you agree, I would suggest that you continue the maintenance on this library and push it to NuGet. You could have ExcelDataReader reference this library then.

But it's your library, so I'm just grateful that I was pointed in this direction.

And yes, TimeSpan backport would be great.