andresdelcampo / GameList_Editor

This repository intends to contribute to GameList Editor development and bring it back to life with the latest systems, etc.
GNU General Public License v3.0
35 stars 0 forks source link

Erreur JPEG #53? #16

Closed wtstreetglow closed 8 months ago

wtstreetglow commented 8 months ago

Hello,

I am getting the subject error when I select "filter for orphans" and pretty much anytime I select anything relating to filters within the software. Is this something I may can correct on my end? Thank you for any guidance you can provide!

If you need anything from me, I may be able to help with some guidance.

andresdelcampo commented 8 months ago

Hi, thanks for reporting that. Maybe a full window screenshot or more detailed steps might help. I have not seen that before... I assume it was with a gamelist already loaded, for example. There has to be some detail that is triggering the issue. Maybe something wrong / corrupted within the gamelist.xml file related to images?

wtstreetglow commented 8 months ago

image

wtstreetglow commented 8 months ago

In my instance the steps are, open program. Select "orphan", in "select your filter" and then the error pops up. I've started messing with it a little more and it looks like a change to anything related to the filtering will create this error.

Also, I just hit ok, in hopes to use the "delete orphans" feature even with the small issue spoken of above, and it has been going for around 4 minutes (trying to delete 700 orphans) and it is still spinning. I'm going to give it around 10 just to see what happens. It seems like the problem being spoken of above may be causing this portion to not work also.

Sorry, I don't know much about programming so just trying to provide as much info a possible?

Would you like a video?

andresdelcampo commented 8 months ago

Hmm... I suspect there may be an issue with the picture referred by that game. Would you mind opening the gamelist.xml file in the Nintendo directory and find the entry for that game, then check what the image tag points to? (or past the whole game entry). Also check if the picture path maps to a file in the drive -I assume it may- and check if you can open that picture with Paint?

wtstreetglow commented 8 months ago

gamelist.zip That's the thing. I don't really understand how to know what game it is. Since it just says Error #53. I don't think it has anything to do with the highlighted 10 yard fight

wtstreetglow commented 8 months ago

image That was another issue I kind of have, but it's not a big one at all since you provide the logo to the right once you select an option in "select your system". In my list, it doesn't seem to be showing system names. Except for a few. Maybe this is "as designed" and no issue if so. See screenshot below. Definitely the least of the issues as compared to the first thing we are speaking of.

wtstreetglow commented 8 months ago

Just letting you know, I attached my gamelist file 2 post back (for nintendo)

wtstreetglow commented 8 months ago

Oh now I'm noticing some really strange stuff. It looks like nintendo is listed a bunch of times in the "select your system" dropdown.

I apologize for just now realizing all of these different things. This was the first time I had set down to start using your extension. I am very thankful for what you have built. I just don't know how to troubleshoot it very good.

image

Below is a screenshot of my directory (1 nes listing):

image

andresdelcampo commented 8 months ago

I suspect the first issue may have been an error trying to load the image for 10 yard fight. The gamelist.xml file may point to what the 10 yard fight image is supposed to be and possibly point to an existing file that may not be a correct jpg format.

Regarding the second issue, that is probably coming from the gamelist xml themselves. They are probably having the tag set to just Nintendo in many of them.

Checking the gamelist... ok there is no provider set, so that might explain why multiple are Nintendo. I have this one for example, for C64:

Commodore 64 Skraper ScreenScraper.fr http://www.screenscraper.fr

image

Try adding something like that to your gamelist.xmls and that should solve the second issue of multiple names.

About the first issue, I can see it points to ./images/10-Yard Fight (U)-image.jpg Does that image exist? Can you open it in Paint?

wtstreetglow commented 8 months ago

I suspect the first issue may have been an error trying to load the image for 10 yard fight. The gamelist.xml file may point to what the 10 yard fight image is supposed to be and possibly point to an existing file that may not be a correct jpg format.

Regarding the second issue, that is probably coming from the gamelist xml themselves. They are probably having the tag set to just Nintendo in many of them.

Checking the gamelist... ok there is no provider set, so that might explain why multiple are Nintendo. I have this one for example, for C64: Commodore 64 Skraper ScreenScraper.fr http://www.screenscraper.fr image

Try adding something like that to your gamelist.xmls and that should solve the second issue of multiple names.

About the first issue, I can see it points to ./images/10-Yard Fight (U)-image.jpg Does that image exist? Can you open it in Paint?

The below looks strange to me. It is on line 53-54. It has no "game id". I trust what you are thinking more than me though. Let me look into what you are saying above.

image

andresdelcampo commented 8 months ago

Also, before fixing the systems issue in the gamelists, make sure it is not transient -that if you reopen the app you still see multiple Nintendos. Because it sounds as if they were fine before? Normally GameListEditor would have taken the directory name in absence of a system.

About the strange entry, I do not think that might be the problem, but you can always try to temporarily remove it to see if it changes anything. It looks like just a game missing a ton of info. Game Id is not required at all. It is just fed by the scraper to make it easier to identify in the future.

wtstreetglow commented 8 months ago

Ok, so it looks like everything is fine on the 10 yard fight photo. See screenshot below.

image

andresdelcampo commented 8 months ago

Can you pass me the jpeg? Maybe I can reproduce the issue with that jpeg. It could still be a format issue. And it looks that way seeing that it cannot be opened in the GameList app. Maybe it is an incompatible format that needs to be converted -you can try to re-save it as JPG with Paint, for example. That might fix it if it is a JPG format issue.

wtstreetglow commented 8 months ago

Also, before fixing the systems issue in the gamelists, make sure it is not transient -that if you reopen the app you still see multiple Nintendos. Because it sounds as if they were fine before? Normally GameListEditor would have taken the directory name in absence of a system.

About the strange entry, I do not think that might be the problem, but you can always try to temporarily remove it to see if it changes anything. It looks like just a game missing a ton of info. Game Id is not required at all. It is just fed by the scraper to make it easier to identify in the future.

I don't think this has ever worked exactly right. I think it did the multiple instances of nes in the old version also. Let me test the old version right quick.

wtstreetglow commented 8 months ago

10-Yard Fight (U)-image

wtstreetglow commented 8 months ago

omg. I'm getting ready to apologize so much I believe the error exist between keyboard and mouse on this one.

wtstreetglow commented 8 months ago

Ok. so the system situation in the "select your system" is corrected by using YOUR version of the software. I was opening the old bad/ original version!! I'm so sorry!!

andresdelcampo commented 8 months ago

I can repro the issue with that image... and the solution suggested works! (open with Paint and resave as JPG with the same name and location and that fixes it :))

No need to apologize for anything. The error could have been more specific.

wtstreetglow commented 8 months ago

The error 53 does still exist

andresdelcampo commented 8 months ago

Looks like both issues are solved! :). Feel free to open more issues if you find them.

wtstreetglow commented 8 months ago

Oh wow, that is strange

andresdelcampo commented 8 months ago

Yes. It is an issue with the specific JPG you passed me. Somehow it is incompatible with GameListEditor -but if you resave it with Paint, it works fine.

wtstreetglow commented 8 months ago

Thank you so much @andresdelcampo. I am so sorry for the "goose chase" at the start and the error on my end using the wrong program for a bit.

wtstreetglow commented 8 months ago

Can you tell me how you determined the very first image had the issue? Blows my mind. How not 200 images down the list?

andresdelcampo commented 8 months ago

Because the program showed a JPG error and no image for 10-yard. Yet the image existed. Therefore it failed loading. I downloaded your image and switched it with one of my games, and got the exact same error. Then I tried resaving it and worked again :).

I have passed the image for analysis to ChatGPT and got a similar result: image

andresdelcampo commented 8 months ago

LOL, I kind of suspected as much... it is not a JPG, it is a PNG renamed as JPG :D

image

andresdelcampo commented 8 months ago

so your alternative fix is to rename the image to png and also the gamelist.xml reference to png as well. But I have not tested that fix. It should work though -unless the png is corrupted as well :D.

wtstreetglow commented 8 months ago

Because the program showed a JPG error and no image for 10-yard. Yet the image existed. Therefore it failed loading. I downloaded your image and switched it with one of my games, and got the exact same error. Then I tried resaving it and worked again :).

I have passed the image for analysis to ChatGPT and got a similar result: image

Haha, I'm an idiot. I didn't even realize what you just said there. haha. Thank you for this response, no I was just wandering how would I have tracked this down if this was 400 games down the list and not right in my face. bad day I believe. lol-- Just in case this were to happen on another system in the future. Thank you for being so helpful.

andresdelcampo commented 8 months ago

Happy to help, and happy new year :)

wtstreetglow commented 8 months ago

@andresdelcampo Thank you and you too!!