andresdelcampo / GameList_Editor

This repository intends to contribute to GameList Editor development and bring it back to life with the latest systems, etc.
GNU General Public License v3.0
35 stars 0 forks source link

Possible systems subfolders support? #20

Closed Oberworld closed 1 month ago

Oberworld commented 1 month ago

As the title of the post indicates, would it be possible to add support for subfolders? Many of my systems contain a subfolder called "homebrew". Homebrew games are often difficult to scrape and Gamelist editor is very useful for editing the metadata. The subfolder is shown in the main menu but I can't access it. All the metadata for the games in "homebrew" subfolder is inside the main gamelist.xml, for example inside roms>nes>gamelist.xml. Thanks in advance, great job with the program. Regards.

andresdelcampo commented 1 month ago

Hmm... having the metadata in the main folder xml makes things a lot easier. So it looks like just patching the rom search to look in subdirectories as well -assuming it is not doing part of that already... I will have a look in the next few days / weekend. Maybe I can give you good news :).

Oberworld commented 1 month ago

Thank you very much. I'll stay tuned.

Muchas gracias por tomarte la molestia andrés. Estaré atento.

andresdelcampo commented 1 month ago

Hi! Hola! I am not sure what the problem is...

image

Maybe it is just making sure that the path tag of your gamelist games points to where they really are? image

Else I do not understand what you are missing in the tool? It seems to handle fine the games that are in subfolders inside that system -they show as part of the system, not as a separate system or folder. That part is unlikely to change. But there are always things that can make the handling easier like adding a "Same path" filter -that is not there yet.

Oberworld commented 1 month ago

I'm sorry, GameList Editor is working fine, I was confused. I have my subfolder named "#Homebrew" and it's in my main gamelist.xml as if it were a game so I can put an image and logo on it.


    <folder>
        <path>./#Homebrew</path>
        <name>#Homebrew</name>
        <image>./images/#Homebrew-image.png</image>
        <marquee>./images/#Homebrew-marquee.png</marquee>
    </folder>

In GameList Editor it does show the first one in the list by its name, and I tried to click to open it, without realizing that what it shows is the folder as a game.

I hadn't noticed that the games were mixed with those in the main system folder.

Anyway, it would be nice if the subfolders were shown on top of the main gamelist and could be clicked so as not to mix all the games in the main system folder.

Sorry so much to have wasted your time, thanks for the help. Regards.

andresdelcampo commented 1 month ago

No problem. The AI fooled me believing there is indeed a folder tag -to later say there is not, or at least not standardized. While a file system-like navigation would be hard to implement, I can think of at least the "Same folder" filter so that after clicking one of the games and filtering, you only see the ones in the same folder. That should not be hard to implement on my end and should mostly address the need to separate the homebrew or in general any subfolder -or the root- from the rest within the same system... if you think it is valuable? What do you think?

Oberworld commented 1 month ago

I think having the option to separate the games by "same folder" as you say, can be useful. At least in my case, many systems even have two subfolders, for example, in zxspectrum, amstradcpc and amiga I have the subfolders homebrew and conversational adventures. I think it would be great to be able to separate the games, but I'm not a programmer and I don't know if it's worth the effort. If it's not a lot of work, it would be great to have that option.

If you decide to do so, it would be nice to put separators (lines) in the game list to separate games that are in different folders.

Example image:

Sin título 1

andresdelcampo commented 1 month ago

Well, the full idea you are proposing would not be that fast... what I was proposing does not disrupt the current flow of the application -it still keeps a single folder content per system, yet it still gives you the chance to see the system with a different filter. Same way we can filter for "Favorites" or by Genre to see only those games, we have filters already for same number of players, for example. If you choose a game with 4 players, then choose the filter Same number of players, then the list only shows those that are for 4 players. I was thinking that I can relatively easily add a new filter "Misma carpeta"/"Same folder" to filter those games that are exactly in the same folder -not subfolders or parent folders... The only drawback is that you start with all and have to locate first a game from that folder to filter the rest. What do you think? Would that help?

image

Oberworld commented 1 month ago

Yes, that would help. Thanks for everything.

andresdelcampo commented 1 month ago

Have a look... it's released :)

Oberworld commented 1 month ago

Wow! That was fast. I'll take a look at it as soon as I can. Thank you so much.

Edit: It's working fine for most systems, but for my Amstrad CPC system, if a let the filter in "All", it's only showing 146 games but I have 839 games. If I try to filter by "Same folder", Game List doesn't do anything.

I need to test and try to find what happen with that especific system. I'll keep you informed.

Oberworld commented 1 month ago

OK, my mistake again, I haven't scraped that system yet because I was doing a "rom cleanup" before scraping everything. Therefore in the gamelist.xml only the games I've tried are shown, even if they are not scraped. Gamelist editor is working great. Thanks a lot for everything, you're doing a great job.

andresdelcampo commented 1 month ago

Awesome! I know it is not a full solution, but if more people show interest I may revisit this with a better solution. In the meantime the workaround should solve most needs :).