andrewgodwin / urlman

Apache License 2.0
119 stars 8 forks source link

Add tests and add full URL helper. #1

Closed jezdez closed 7 years ago

jezdez commented 7 years ago

This also fixes Python 3 support and sets up running tox via Travis CI.

jezdez commented 7 years ago

@andrewgodwin A few questions:

andrewgodwin commented 7 years ago

I haven't looked at this in two years, so it's taking a bit of remembering - bear with me!

jezdez commented 7 years ago

@andrewgodwin So this is ready for another look. I've added code to enable Codecov on Travis-CI but you may need to go to Codecov actively and enable the repo there.

One thing I noticed is the non-existence of a license file. Which license do you want this to be published?

andrewgodwin commented 7 years ago

Lovely, thanks. I think it's ready to merge in if you're OK with that; I can add in the license file myself (I usually go with Apache 2, and see no reason to not keep doing that here)

jezdez commented 7 years ago

@andrewgodwin works for me!

andrewgodwin commented 7 years ago

Looks like the Travis builds worked for 2.7 and 3.4, but not 3.5 or 3.6, and I don't know why it can't find the python3.5 binary. Any idea? https://travis-ci.org/andrewgodwin/urlman/builds/223717184