andrewgodwin / urlman

Apache License 2.0
117 stars 8 forks source link

Introduce get_scheme and get_hostname on Url classes #6

Closed rixx closed 6 years ago

rixx commented 6 years ago

Closes maybe, but at least references #4.

I hope this provides a fairly readable change, but please request changes if anything seems wonky to you!

codecov-io commented 6 years ago

Codecov Report

Merging #6 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          79     89   +10     
  Branches        9     10    +1     
=====================================
+ Hits           79     89   +10
Impacted Files Coverage Δ
urlman.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0bafc9...cad36c8. Read the comment docs.

andrewgodwin commented 6 years ago

Ta!