search

andrewhancox / moodle-filter_translations

7 stars 8 forks source link

Editing missing translations deletes all missing translation issues for target language #140

Closed rjnl closed 1 year ago

rjnl commented 1 year ago

When you edit a translation from the missing translations page:

  1. a new translation record will be created
  2. all missing translation records are deleted for the target language

Expected behaviour should be to only delete missing translation entries that match the target language and hash.

This is due to https://github.com/andrewhancox/moodle-filter_translations/blob/417f167d2c8069766d4b401c6085afb0d0edb780/classes/translation_issue.php#L110 in function remove_records_for_translation($translation)

rjnl commented 1 year ago

Fixed by: https://github.com/rjnl/moodle-filter_translations/commit/eb804465763c06e6124d7007be63d57a93a997de