search

andykuszyk / noman.el

An Emacs package for browsing CLI command docs without man pages
GNU General Public License v3.0
13 stars 4 forks source link

Apply MELPA submission notes #7

Closed progfolio closed 2 months ago

progfolio commented 2 months ago

Add noman defgroup. noman-parsing-functions: promote to user option, add type noman-menu: signal user-error when no sub-commands found noman-back: signal user-error when history exhausted noman--aws-button, noman--default-button: rename, use when-let, cache line-beginning-position noman--get-button-func: rename, use alist-get with DEFAULT, TEST parameters noman--exec: replace with call-process noman--make-buttons: rename, simplify buffer traversal noman-mode-map: remove redundant special-mode quit-window binding noman-mode: add keymap to docstring. noman: decompose buffer handling logic into noman--buffer, argument reading into noman--read-cmd noman--buffer: prepare single noman buffer. Prefers displaying in same window, sets command in header-line.

andykuszyk commented 2 months ago

@progfolio thanks so much for this contribution, I'll really appreciate your advice and feedback. I'll take a detailed look over the next week or so🙏

andykuszyk commented 2 months ago

@progfolio thanks again for this contribution 🙏

It looks like there are a couple of test failures on this branch, so I will merge it into another branch within this repo to fix the tests, before merging to main 👍