search

angristan / feedbin-docker

Self-host your own Feedbin RSS reader in Docker
MIT License
251 stars 35 forks source link

Alpine images #35

Closed karlprieb closed 3 years ago

karlprieb commented 3 years ago

Why not use Alpine as base for the images? They're smaller, more secure and sometimes faster. If there's nothing against Alpine can I create a PR changing the Dockerfiles?

Thanks for this project... without this project is almost impossible to self host Feedbin!

angristan commented 3 years ago

Alpine is not always the best choice: https://pythonspeed.com/articles/alpine-docker-python/. I don't really care about image size anymore to be honest. I don't mind using Alpine if you want to make a PR though 🙂

karlprieb commented 3 years ago

Yep... I suggested Alpine because it has less things so less surface area for security issues, but I agree that sometimes it's a pain to deal with musl. I run alpine on my laptop and server so I'm little biased, but as we can see on this article for Python the situation is horrible. I know that for node is great, but really don't know for ruby as I never worked with ruby. So let's just let the things how they are now (it's working fine) and if someone need smaller images I can create a PR for that as I'm already using here.

Thanks for your reply!

karlprieb commented 3 years ago

I'll close this as I discovered that rubyjs doesn't work without glibc (used for v8).