angristan / feedbin-docker

Self-host your own Feedbin RSS reader in Docker
MIT License
251 stars 35 forks source link

A lot of improvements #65

Closed karlprieb closed 3 years ago

karlprieb commented 3 years ago

So, I really love this project. There's no way to self host feedbin without this project. Thanks a lot @angristan

I've been using this project for some months now and I already made a lot of changes on my feedbin deploy. I think that all my changes are not aligned with this project, but today I updated my fork with those changes and I think it make sense to create this PR. If some changes don't make sense for this project I can create other PR with just the changes that you @angristan agree with :)

I know that is not a good practice to make a huge PR like that, but it's easier for me, so... that's it :)

To the changes:

That's all :)

angristan commented 3 years ago

That looks good! Thank for your work!

karlprieb commented 3 years ago

I fixed the things that you commented. As before we still have some linting issues regarding some alpine packages not having your versions pinned. I really don't think that should be an issue as the packages that we really need to pin are already pinned. What do you think @angristan ? Another issue is [ERROR] Please set a [GITHUB_TOKEN] from the main workflow environment to take advantage of multiple status reports!. There's nothing I could do to fix that as it should be a repository secret, right?

karlprieb commented 3 years ago

@angristan any update?

angristan commented 3 years ago

Let me fix the CI

angristan commented 3 years ago

Mmmh yeah, you can add DL3018 to .github/linters/.hadolint.yml

karlprieb commented 3 years ago

@angristan done :)

angristan commented 3 years ago

Thank you again for your work 👌

iSwiftLiu commented 3 years ago

Thank you very much.

kzshantonu commented 3 years ago

Hi thanks for everything. Minio seems fixed and uploading OPMLs work. But they don't import successfully. I get this in sidekiq:

Excon::Error::Socket: SSL_connect returned=1 errno=0 state=error: tlsv1 alert internal error (OpenSSL::SSL::SSLError)

karlprieb commented 3 years ago

Hey @kzshantonu ill take a look as soon as I have some time... In the meanwhile can you open an issue about this?

kzshantonu commented 3 years ago

@karlprieb sure thanks