search

angular-fullstack / generator-angular-fullstack

Yeoman generator for an Angular app with an Express server
https://awk34.gitbook.io/generator-angular-fullstack
6.12k stars 1.24k forks source link

Socket fails in strict DI mode & stylus bootstrap import fails #2220

Open syzer opened 8 years ago

syzer commented 8 years ago
Item Version
generator-angular-fullstack x.x.x
Node x.x.x
npm x.x.x
Operating System OS X 10 / Windows 10 / Ubuntu 15.10 / etc
etc etc
Item Answer
Transpiler Babel / TypeScript
Markup HTML / Pug
CSS CSS / LESS / SCSS / Stylus
Router ngRoute / ui-router
Client Tests Jasmine / Mocha
DB MongoDB / SQL
Auth Y / N
etc etc

Socket is not using explicit annotation and cannot be invoked in strict mode

syzer commented 8 years ago

also build fails if you pick stylus.... IMHO generator in version 4 is not usable

syzer commented 8 years ago 
ERROR in ./~/css-loader!./~/stylus-loader!./client/app/app.styl
Module build failed: Error: ../node_modules/bootstrap-styl/bootstrap/index.styl:8:9
    4|  * Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
    5|  */
    6|
    7| // Core variables and mixins
    8| @import "bootstrap/variables"
--------------^
    9| @import "bootstrap/mixins"
   10|
   11| // Reset and dependencies

failed to locate @import file bootstrap/variables.styl
syzer commented 8 years ago

wasted 4 hours of my life... stylus do not work css works

but with ui.router socket do not work!

strictDi: true => strictDi: false fixes problem

Koslun commented 8 years ago

If there is an actual issue it is imperative that you actually fill in what version and configuration you're using in detail. There are many issues fixed between even minor version changes.

You've hinted at the configuration that is likely relevant but always good to know exactly what you're using so someone else can replicate it perfectly. So edit this with your version and exact configurations you've tried.

Item | Version
----- | -----
generator-angular-fullstack | x.x.x
Node | x.x.x
npm | x.x.x
Operating System | OS X 10 / Windows 10 / Ubuntu 15.10 / etc
etc | etc

Item | Answer
----- | -----
Transpiler | Babel / TypeScript
Markup | HTML / Jade
CSS | CSS / LESS / SCSS / Stylus
Router | ngRoute / ui-router
Build Tool | Grunt / Gulp
Client Tests | Jasmine / Mocha
DB | MongoDB / SQL
Auth | Y / N
etc | etc

Taking it that you've found two different bugs so would ideally also be better to file two different issues.

Seems like the Stylus bug is "just" about fixing the bootstrap import. Might check that out myself.

Switching off strictDi is probably just a handy quick-fix for sockets so would have to check that out in more detail for a permanent fix.

Awk34 commented 8 years ago

See #2208 for socket service fix (merged 4 days before this issue was opened)

syzer commented 8 years ago

merged but probably not published :) ?