use of Modal.service - Githubissues

marwenlandoulsi commented 7 years ago

[x] I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.

Item	Version
generator-angular-fullstack	4.1.0
Node	6.9.1
npm	3.10.8
Operating System	Windows 10

Item	Answer
Transpiler	Babel
Markup	HTML
CSS	CSS
Router	ui-router
Client Tests	Jasmine
DB	MongoDB
Auth	Y

I need help : when i use the modal.service.js, i got this bug. any solution please.

this is my Admin.controller.js :

'use strict';

export default class AdminController {
  users: Object[];
  $http;
  /*@ngInject*/
  Modal;

  constructor(User, $http, Modal) {
    // Use the User $resource to fetch all users
    this.users = User.query();
    this.$http = $http;
    this.Modal = Modal;
  }

  delete(user) {

    this.Modal.confirm.delete(user => {
      user.$remove();
      this.users.splice(this.users.indexOf(user), 1);
    });
  }
}

and the app. js :

import Modal from '../components/modal/modal.service';

angular.module('safetyWayApp', [ngCookies, ngResource, ngSanitize, 'btford.socket-io', uiRouter,
  uiBootstrap, _Auth, account, AddAccidentComponent,
  accident, admin, navbar, footer, main, constants, socket, util, angularUtilsPagination, Modal
])
  .config(routeConfig)
  .run(function ($rootScope, $location, Auth) {
    'ngInject';
    // Redirect to login if route requires auth and you're not logged in

    $rootScope.$on('$stateChangeStart', function (event, next) {
      Auth.isLoggedIn(function (loggedIn) {
        if (next.authenticate && !loggedIn) {
          $location.path('/login');
        }
      });
    });
  });

angular.element(document)
  .ready(() => {
    angular.bootstrap(document, ['safetyWayApp'], {
      strictDi: true
    });
  });

finnaly this is the bug :

Awk34 commented 7 years ago

In client/components/modal/modal.service.js, after this line:

export function Modal($rootScope, $uibModal) {

add this:

'ngInject';

It might be easier to use the ui-bootstrap modal directly, though.

marwenlandoulsi commented 7 years ago

same problem :(

Awk34 commented 7 years ago

Please fix the code formatting in your OP so I can read it

marwenlandoulsi commented 7 years ago

done i fix it

Awk34 commented 7 years ago

The placement of your /*@ngInject*/ directive is incorrect. See https://github.com/huston007/ng-annotate-loader & https://github.com/olov/ng-annotate#library-api

marwenlandoulsi commented 7 years ago

thinks it's work :)

angular-fullstack / generator-angular-fullstack

use of Modal.service #2434