angular-fullstack / generator-angular-fullstack

Yeoman generator for an Angular app with an Express server
https://awk34.gitbook.io/generator-angular-fullstack
6.12k stars 1.24k forks source link

user.controller.js:show seems to be dead code #2520

Open nstuyvesant opened 7 years ago

nstuyvesant commented 7 years ago
Item Version
generator-angular-fullstack 4.1.4
Node 7.7.3
npm 4.4.1
Operating System OS X 10
Item Answer
Transpiler Babel
Markup Pug
CSS SCSS
Router ui-router
Client Tests Mocha
DB Sequelize
Auth Y

If I scaffold out a project using the settings above, it seems that /server/api/user/user.controller.js:show is not used anywhere (GET /api/users/:id) other than the generated index.spec.js.

Instead, user.controller.js:me (GET /api/users/me) seems to be the only way a single user is retrieved.

I'm using Sequelize so perhaps this is in there for Mongoose only?

I might be overlooking something. Could someone else double-check this?

Awk34 commented 7 years ago

Yes, it appears that it is not used anywhere

nstuyvesant commented 7 years ago

Thanks for verifying!